Patch edk2-ovmf file to fix UEFI support #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGarbutt
previously approved these changes
Jan 18, 2023
|
I've just realised this needs to be made specific to centos as it might fail on Ubuntu. |
oops, you are quite correct. |
The file 50-edk2-ovmf-cc.json is used by Nova in get_loader() when
lauching UEFI instances without Secure Boot.
It only supports machine type pc-q35-rhel8.5.0. However, with recent
nova-compute container images built on CentOS Stream 8, the machine type
is pc-q35-rhel8.6.0, which results in failures to launch instances with:
nova.exception.UEFINotSupported: UEFI is not supported
There is a fix for RHEL9/c9s [1], but not for RHEL8/c8s. Also see [2]
for more details.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2090752
[2] https://bugs.launchpad.net/nova/+bug/1955035
priteau
force-pushed
the
edk2-ovmf-uefi
branch
from
b347ed4 to
72e2f72
Compare
markgoddard
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file 50-edk2-ovmf-cc.json is used by Nova in get_loader() when lauching UEFI instances without Secure Boot.
It only supports machine type pc-q35-rhel8.5.0. However, with recent nova-compute container images built on CentOS Stream 8, the machine type is pc-q35-rhel8.6.0, which results in failures to launch instances with:
There is a fix for RHEL9/c9s [1], but not for RHEL8/c8s. Also see [2] for more details.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2090752
[2] https://bugs.launchpad.net/nova/+bug/1955035